test: PR requires e2e tests to pass#2221
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new GitHub Actions workflow to run the repository’s Playwright E2E suite against the full “local stack” (Docker Compose services + host-run apps) on pull requests targeting main, making E2E results available as a required CI signal.
Changes:
- Adds
.github/workflows/e2e.ymlto runpnpm local:setup, start the host apps, wait for readiness, and executepnpm e2e:test. - Uploads Playwright artifacts (
playwright-report,test-results) and dumps service logs on failure.
bosbaber
force-pushed
the
stephan/int1-629
branch
from
1b613b6 to
006547a
Compare
dragosp1011
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR - PRs will now trigger running of automated e2e tests
Auto generated
This pull request introduces a comprehensive end-to-end (E2E) test for cross-currency payment transfers between EUR and USD accounts in the wallet application. It adds a new scenario to the feature file, implements all related test steps and helper functions, and ensures the E2E workflow is executed in CI via GitHub Actions. The main changes are grouped below.
E2E Cross-currency Payment Test Implementation:
cross-currency-transfer.feature, covering the full user flow from account setup, deposit, payment, and transaction verification.cross-currency-transfer.steps.ts, including logic for account creation, deposits, sending payments, confirmation, and transaction polling with robust handling for asynchronous settlement. [1] [2]findTransactionandparseAmountFromTextto reliably locate and verify transactions on the relevant account pages, handling timing and parsing issues.Test State and Workflow Enhancements:
FlowStatetype infixtures.tsto track all necessary state for cross-currency transfers (account IDs, paths, wallet addresses, and expected amounts)..github/workflows/e2e.ymlto run Playwright E2E tests in CI, including setup, environment configuration, service orchestration, and test artifact uploads.